Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[박규한 | 손영진] - 컴포넌트 설계 및 프로젝트 테마 설정 #6

Merged
merged 8 commits into from
Jan 21, 2025

Conversation

rbgksqkr
Copy link

@rbgksqkr rbgksqkr commented Jan 20, 2025

시연 화면

image

컴포넌트 설계

image

주요 작업

  • 컴포넌트 설계
  • 리액트 프로젝트 설정 (vite, styled-components)
  • 테마 설정 (colors, fonts)
  • 글로벌 스타일 설정 ( + reset.css)
  • 홈화면 UI 퍼블리싱 60%

@rbgksqkr rbgksqkr self-assigned this Jan 20, 2025
@rbgksqkr rbgksqkr changed the title [박규한손영진] - 컴포넌트 설계 및 프로젝트 테마 설정 [박규한 | 손영진] - 컴포넌트 설계 및 프로젝트 테마 설정 Jan 20, 2025
@rbgksqkr rbgksqkr assigned rbgksqkr and unassigned rbgksqkr Jan 20, 2025
Copy link
Contributor

@crongro crongro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컴포넌트가 벌써 있군요.
styled코드를 컴포넌트에서 분리하는 경우도 있는데, 단일 컴포넌트의 응집도가 떨어지는 단점도 있긴해요.
장단점이 있는것이니 이런점을 느끼면서 개발해보세요.

Comment on lines +11 to +12
<ThemeProvider theme={theme}>
<GlobalStyle />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme 와 globalstyle의 차이도 있긴하죠.
요것도 살짝 알아두고 잘 구분해서 적용해보세요.

@crongro crongro merged commit 42be669 into softeer5th:dubu Jan 21, 2025
crongro pushed a commit that referenced this pull request Jan 24, 2025
컴포넌트 배치 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants